Use for loop in example with multiple values#73
Open
openjck wants to merge 1 commit intodocopt:masterfrom
Open
Use for loop in example with multiple values#73openjck wants to merge 1 commit intodocopt:masterfrom
openjck wants to merge 1 commit intodocopt:masterfrom
Conversation
openjck
force-pushed
the
readme-multiple-values-for-loop
branch
from
1bdfd2e to
92ca97b
Compare
Collaborator
|
Hello @openjck Thanks for your contribution... This is very cosmetic change about the doc. Some parts are imported directly from source code. So I didn't took time to verify the code yet. Also I don't use the ugly bash fake nested array syntax. So it's probably some legacy code here. Did you have a look at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last example, which uses an argument with multiple values, can be made more terse by using a
forloop. I think this is an improvement, but whether others agree is subjective and a matter of style, so I'd understand if this change is not accepted.